ESP32 examples: adaptation to post-1.0.0-rc0 API changes #469
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
finalyards
commented
Oct 3, 2025
finalyards
commented
Oct 3, 2025
finalyards
commented
Oct 3, 2025
examples/esp32/Cargo.toml
Outdated
| esp-radio = { version = "0.15.0", features = [ "unstable", "ble" ] } | ||
| esp-preempt = { version = "0.0.1", features = ["log-04"] } | ||
| esp-radio = { version = "0.15.0", features = ["ble", "log-04", "unstable"] } | ||
| esp-rtos = { version = "0.0.1", features = ["embassy", "log-04"] } |
There was a problem hiding this comment.
Background: esp-hal-embassy will be gone; esp-preempt was the interim name for the replacement, which eventually will be esp-rtos. The purpose (of esp-hal) is to consolidate async under one module. .
finalyards
commented
Oct 3, 2025
finalyards
commented
Oct 3, 2025
finalyards
commented
Oct 3, 2025
finalyards
commented
Oct 3, 2025
finalyards
commented
Oct 3, 2025
| #[cfg(feature = "esp32")] | ||
| { | ||
| esp_hal_embassy::init(timg0.timer1); | ||
| } |
There was a problem hiding this comment.
Those blocks are no longer needed, due to the API change (esp_rtos).
finalyards
commented
Oct 3, 2025
| use esp_radio::Controller; | ||
| use static_cell::StaticCell; | ||
| //use esp_radio::Controller; | ||
| //use static_cell::StaticCell; |
There was a problem hiding this comment.
From here on, it's the same story for each of the samples.
|
thanks for doing this! |
|
1.0.0-rc1 was released yesterday |
finalyards
force-pushed
the
pr-esp-hal-031025
branch
2 times, most recently
from
736d8bd to
9b171b4
Compare
finalyards
commented
Oct 15, 2025
| esp-alloc = { version = "0.9.0" } | ||
| esp-println = { version = "0.16.0", features = ["log-04"] } | ||
| esp-radio = { version = "0.16.0", features = ["ble", "log-04", "unstable"] } | ||
| esp-rtos = { version = "0.1.1", features = ["embassy", "esp-alloc", "esp-radio", "log-04"] } |
There was a problem hiding this comment.
Not sure if the esp-alloc feature is needed. Likely works both with or without.
finalyards
commented
Oct 15, 2025
finalyards
force-pushed
the
pr-esp-hal-031025
branch
from
9b171b4 to
c62be86
Compare
|
/test |
…_bas_peripheral_bonding conversions
finalyards
force-pushed
the
pr-esp-hal-031025
branch
from
c62be86 to
cff9dc5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The upcoming embassy changes in
esp-halare already documented, and can be prepared for.This PR updates the
examples/esp32to be prepared for the next 1.0.0-rc version. I advocate that this wouldn't be merged, until rc1 or similar, is released. But we can already fine tune the examples.